Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ticdc: Support Vector data type #11620

Merged
merged 45 commits into from
Sep 24, 2024
Merged

ticdc: Support Vector data type #11620

merged 45 commits into from
Sep 24, 2024

Conversation

wk989898
Copy link
Contributor

What problem does this PR solve?

Issue Number: ref #11530

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note 

support vector data type

wk989898 and others added 30 commits August 12, 2024 11:02
@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-triage-completed release-note Denotes a PR that will be considered when it comes time to generate release notes. area/dm Issues or PRs related to DM. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 23, 2024
@wk989898
Copy link
Contributor Author

/area ticdc

@ti-chi-bot ti-chi-bot bot added the area/ticdc Issues or PRs related to TiCDC. label Sep 24, 2024
@codecov Codecov
Copy link

codecov bot commented Sep 24, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 52.83019% with 75 lines in your changes missing coverage. Please review.

Project coverage is 57.5179%. Comparing base (592a62f) to head (1a3136a).
Report is 3 commits behind head on master.

Additional details and impacted files
Components Coverage Δ
cdc 61.2177% <52.8301%> (∅)
dm 51.1501% <ø> (+0.1046%) ⬆️
engine 63.4161% <ø> (+0.0070%) ⬆️
Flag Coverage Δ
unit 57.5179% <52.8301%> (+3.7260%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master     #11620        +/-   ##
================================================
+ Coverage   53.7918%   57.5179%   +3.7260%     
================================================
  Files           403        852       +449     
  Lines         63755     126677     +62922     
================================================
+ Hits          34295      72862     +38567     
- Misses        26772      48425     +21653     
- Partials       2688       5390      +2702

@wk989898
Copy link
Contributor Author

/retest

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 24, 2024

@flowbehappy: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Sep 24, 2024
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 24, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 3AceShowHand, flowbehappy, lance6716

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added approved lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 24, 2024
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 24, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-09-24 08:22:06.014933014 +0000 UTC m=+1554195.755356953: ☑️ agreed by 3AceShowHand.
  • 2024-09-24 09:00:54.102700411 +0000 UTC m=+1556523.843124351: ☑️ agreed by lance6716.

@wk989898
Copy link
Contributor Author

/retest

1 similar comment
@wk989898
Copy link
Contributor Author

/retest

@ti-chi-bot ti-chi-bot bot merged commit 021fd64 into pingcap:master Sep 24, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lance6716 lance6716 lance6716 approved these changes

@flowbehappy flowbehappy flowbehappy approved these changes

@3AceShowHand 3AceShowHand 3AceShowHand approved these changes

Assignees
No one assigned
Labels
approved area/dm Issues or PRs related to DM. area/ticdc Issues or PRs related to TiCDC. lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@wk989898 @lance6716 @flowbehappy @3AceShowHand @CharlesCheung96